allthingssecurity commented on PR #29533: URL: https://github.com/apache/camel/pull/29533#issuecomment-6762086934
Thanks for the review. In ce67c8195196: - Docs: the "Caching Jdbc IdempotentRepository" section now explains that a second add of the same key on the same node, made while the first is still uncommitted, does not hit the cache. It gets a duplicate key error and its transaction is rolled back once before the redelivery is filtered, as with the plain JDBC repository or several nodes. The catalog copy is the same. - The comment on the second `cache.remove` in `remove()` now says it narrows the window and does not close it, since that add's `afterCommit` runs after the commit has released the row lock. I updated the PR description to match. - REQUIRES_NEW: agreed, left as is, as in the sibling repository. _Claude Code on behalf of allthingssecurity_ -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
