Dhairya-007 commented on PR #29550: URL: https://github.com/apache/camel/pull/29550#issuecomment-6763445343
Thanks both — you were right, only part of the change had been pushed and none of the sources. The full change is in now, 18 commits on top of the original one, one per component plus `camel-main` and a `core` commit for the javadoc that does not feed the catalog. **Sources are fixed first now.** Every `@UriParam`/`@Metadata` literal and setter javadoc the generator reads is edited, so a regen no longer reverts anything: `AtomEndpoint`, `ChatScriptEndpoint`, `ControlBusEndpoint`, `DigitalSignatureConfiguration`, `CxfRsEndpoint`, `GoogleMailStreamConstants`, `HazelcastSedaConfiguration`, `JGroupsRaftConstants`, `JiraConfiguration`, `KnativeComponent`, `Olingo2App`/`Olingo4App`, `RobotFrameworkCamelConfiguration`, `SalesforceComponent`, `SolrConfiguration`, `WeatherConfiguration`, `Web3jConfiguration`, `Web3jConstants`, `MainConfigurationProperties` and `DefaultConfigurationProperties`. **The missing pieces are all added:** the other 13 components, both olingo modules (which were absent entirely), the four remaining `Certficates` in `DigitalSignatureEndpointBuilderFactory`, `CryptoComponentBuilderFactory`, `controlbus-component.adoc` and `main.adoc` with their `camel-catalog` mirrors, and the `IOHelper`/`InternalProcessor`/`SharedInternalProcessor`/`CamelInternalProcessor`/`SharedCamelInternalProcessor`/`Budget`/`RemoveHeadersProcessor`/`RemovePropertiesProcessor`/`CamelContextFactoryBean` javadoc plus `stream-caching.adoc`. 91 files, 169 lines each way. **On `entrys`:** the two reviews disagreed, and I went with @gnodet's `entry's` over `entries`. The sentence is "checks the Atom entry's updated or published date is newer than the previously read entry" — a plural noun with a singular `date` does not parse, and the closing clause is singular too. Say the word and I will switch it back. **What I checked, since the generated copies are updated by hand:** - Every component JSON is byte-identical to its `camel-catalog` copy (20 mirror pairs, including the camel-main metadata and both adocs). - Each DSL javadoc block I touched is re-wrapped the way the generator does it: greedy to 80 columns including the ` * ` prefix. I verified the algorithm by reproducing the untouched blocks byte-for-byte, then checked all 21 touched description runs are ≤ 80 and maximally filled. - `ControlBusEndpoint.setAction`'s javadoc paragraph is re-wrapped too, because `statistics` pushed a line to 122 and the Eclipse config wraps comments at 120 (`comment.line_length`). Reproducing that wrap against `main` matched byte-for-byte. The two remaining over-128 lines in the diff, in `AtomEndpoint` and `SalesforceComponent`, are string-literal concatenations the formatter does not split; both files already carry several of those on `main`. - A repo-wide scan finds no occurrence of any of the 18 misspellings left outside test fixtures. The ones left alone on purpose are the `camel-cassandra.yaml`, `big-payload.json` and `MyConfiguration` test data, and "base class statics" in an AS2 test, which means static fields. I could not run the regen locally, so if CI's `mvn install` produces a diff I will take its patch verbatim. On the overlap with #29539: it changes the `certificateName` line and this one changes `keystore`/`keyStoreParameters` right below it, both from the Java source now. Whichever merges second I will rebase and regenerate. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
