gnodet-bot commented on PR #29579:
URL: https://github.com/apache/camel/pull/29579#issuecomment-6780702603
The mechanical `<tt>` → `<code>` and `<p/>` → `<p>` replacements look
correct overall, but I noticed that three of the touched Javadoc blocks contain
pre-existing factual errors that the PR modifies without fixing:
1. **`FileUtil.java` — `isWindowsDrive()` has completely wrong Javadoc.**
The description says *"Determines whether the URI has a scheme (e.g.
file:, classpath: or http:)"*, and the `@param` names `uri` — but the actual
method is `isWindowsDrive(String part)` and checks whether a string looks like
a Windows drive letter (`C:`). The `@return` line was touched by this PR. It
would be good to fix the description, `@param` name and `@return` semantics at
the same time.
2. **`IOHelper.java` — typo *"at the of the text"*.**
Line touched by this PR reads: *"This implementation appends a `\n` as
line terminator at the of the text."* — missing the word `end`.
3. **`ObjectHelper.java` — nonsensical sentence *"Returns the first non null
object `null`."***
The sentence doesn't make sense as written. The method returns
`Optional<Object>`, so something like *"Returns the first non-null object, or
an empty `Optional` if all are null."* would be accurate.
These are all pre-existing issues, not regressions introduced by this PR,
but since the lines are already being touched it's a good opportunity to clean
them up.
<!-- hermes-bot-review -->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
