gnodet-bot commented on code in PR #29591:
URL: https://github.com/apache/camel/pull/29591#discussion_r4533343384
##########
components/camel-ai/camel-docling/src/main/java/org/apache/camel/component/docling/DoclingConfiguration.java:
##########
@@ -128,7 +128,9 @@ public class DoclingConfiguration implements Cloneable {
private AuthenticationScheme authenticationScheme =
AuthenticationScheme.NONE;
@UriParam(label = "security")
- @Metadata(description = "Header name for API key authentication",
defaultValue = "X-API-Key")
+ @Metadata(description = "Header name for API key authentication",
defaultValue = "X-API-Key",
+ deprecationNote = "Not used: the docling-serve client always
sends the API key in the X-Api-Key header")
Review Comment:
💡 **Nit:** The `deprecationNote` text says `X-Api-Key` but the field's
`defaultValue` and the actual field initializer use `X-API-Key`. HTTP headers
are case-insensitive per [RFC 7230
§3.2](https://datatracker.ietf.org/doc/html/rfc7230#section-3.2), so there's no
functional impact — but it may be worth making the casing consistent (pick one
spelling across both).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
