davsclaus commented on PR #29621:
URL: https://github.com/apache/camel/pull/29621#issuecomment-6793347545
Thanks for the review. Addressed in e44b542aafbf:
- **Stale picocli comments**: fixed in `CliRunner` (and its `help`/`usage`
writers, which nothing wrote to any more, are gone), and in `CamelJBangMain`,
`CamelCommand`, `UsageErrorHandler` and `SilentRunDependencyResolver`. The
comments that compare with picocli on purpose ("as picocli printed it") stay.
The `filePaths` fields "only declared for file path completion" (5 commands)
had no annotation left after the port, so they did nothing on aesh: removed.
- **`<picocli-version>`**: removed. The test plugin gets picocli from Citrus
5.1 until [CAMEL-26852](https://issues.apache.org/jira/browse/CAMEL-26852)
(Citrus 5.2.0 on aesh).
- **`jarUrl.getPath()` in `scanJarForPlugins`**: confirmed, a CLI installed
in a folder with a space loses its embedded plugins (the
`FileNotFoundException` is ignored). It predates this PR, which only changed
the signature, so it gets its own JIRA and fix rather than growing this PR.
While checking, the second (serial) test execution of camel-jbang-core
turned out to have 11 failures that my earlier runs never reached: two tests
written for picocli, and one real difference, now fixed: `camel run` printed
the `camel config` values only for an option configured by its first name
(`dev=true` for `--reload,--dev` was not printed). Now 2776 + 321 pass locally.
_Claude Code on behalf of davsclaus_
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
