davsclaus opened a new pull request, #29636:
URL: https://github.com/apache/camel/pull/29636

   # Description
   
   Prepares the Scalpel 0.5.0 bump (#29611).
   
   In Scalpel 0.5.0 a changed root-level file that no module owns (for example 
`CLAUDE.md`) triggers a full build 
([maveniverse/scalpel#229](https://github.com/maveniverse/scalpel/issues/229), 
`ModuleMapper`), even with our empty `-Dscalpel.fullBuildTriggers=`. 
`incremental-build.sh` reads `fullBuildTriggered` as a Scalpel failure and 
drops Scalpel's module list. A PR that touches `CLAUDE.md` alongside a POM 
change would then lose the downstream modules that Scalpel found.
   
   This PR adds the root-level files that do not affect the build to 
`-Dscalpel.excludePaths`, next to `.github/**`:
   `AGENTS.md, CLAUDE.md, CONTRIBUTING.md, README.md, SECURITY.md, KEYS, 
LICENSE.txt, NOTICE.txt, doap.rdf, Jenkinsfile*, .asf.yaml, .gitattributes, 
.gitignore, .gitmodules, .sdkmanrc, jbang-catalog.json`.
   
   - `mvnw`, `mvnw.cmd` and `pom.xml` are left out on purpose, so a change to 
them still triggers a full build.
   - Scalpel turns a pattern without a `/` into `{p,**/p}`, so these names also 
match inside modules, for example `dsl/camel-jbang/camel-jbang-core/CLAUDE.md`. 
That only hides the file from Scalpel: the file-path step of the script still 
adds the module of such a file to the build.
   - I checked the patterns with Java's `glob:` `PathMatcher`, the way Scalpel 
0.5.0's `PathFilters` builds them:
     - excluded: `CLAUDE.md`, `Jenkinsfile.jdk26`, `.github/workflows/x.yml`;
     - kept: `pom.xml`, `mvnw`, `parent/pom.xml`, `.mvn/extensions.xml` and 
module sources.
   
   `CI-ARCHITECTURE.md` documents the setting.
   
   🤖 Generated with [Claude Code](https://claude.com/claude-code)
   
   https://claude.ai/code/session_016Y4dDiMc7mxmdVoQiGSMh8


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to