Croway commented on PR #29594:
URL: https://github.com/apache/camel/pull/29594#issuecomment-6800185971
The docling-serve side looks right: `doctags_content` is only filled when
DocTags is requested, and an in-body response never carries split-page HTML
(docling-jobkit `_export_document_as_content`). So the extractor case and the
`html_split_page` rejection fix real empty bodies.
1. **The CLI changes can't be reached.** `outputFormat` and
`CamelDoclingOutputFormat` are only read by `SUBMIT_ASYNC_CONVERSION`
(`DoclingProducer.java:371`), which only works against docling-serve. Every CLI
call passes a fixed format: `"markdown"`, `"html"`, `"json"` or `"text"` (lines
309, 321, 331, 343, 353, 717).
- I ran every CLI operation with `outputFormat=doctags`, as the option
and as the header, against a fake `docling` script. On main and on this branch
it always got `--to md/html/json/text`.
- So the new cases in `mapToDoclingFormat` / `getOutputFileExtension`,
`DoclingOutputFormatTest`, and the second paragraph of the upgrade-guide entry
describe a change no route can see. (The earlier review asked for the CLI
`html_split_page` mapping, but the CLI never receives that value either.)
- Please drop the CLI half, or keep it as symmetry but remove the CLI
claims from the upgrade guide and the description.
2. **Formatting:** `mvn formatter:format` rewraps the class Javadoc of
`DoclingServeOutputFormatTest`, and CI fails on the uncommitted change.
3. **Description:** it still says `html_split_page` is "deliberately left as
it is".
4. **Conflict with #29595:** both PRs change the `buildConvertRequest`
signature. Whichever merges second has to adapt `DoclingServeOutputFormatTest`
to `buildConvertRequest(source, format, exchange)`.
_Claude Code on behalf of Croway_
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
