Dhairya-007 commented on PR #29643:
URL: https://github.com/apache/camel/pull/29643#issuecomment-6802082295
Thanks both — you're right on all three, and I've pushed fixes.
**The two intentional examples are reverted.** `closestMethodName`'s "a typo
such as `lenght` for length" and `QuickFixes`' `"peroid → period"` label both
use a misspelling on purpose to show what the code handles; correcting them
made the examples say nothing. That was a blind spot in how I built the list
—
codespell can't tell a typo from an example of one, and I didn't check for
that class. I re-read the remaining 112 corrections on this branch for the
same shape and found no others.
**The formatter point is real, and it was worse than the two lines you
found.** Dropping a repeated word shortens a Javadoc line, which leaves room
for the next word, and with `join_lines_in_comments=true` and
`comment.line_length=120` the formatter pulls it up. Two paragraphs on this
branch were affected:
- `DefaultComponent:396` — "delegate the the" → "delegate the" left room for
`endpoint's`.
- `SimpleTypeConverter:27` — `Implementators` → `Implementers` left room for
`of`.
Both paragraphs are now re-wrapped as the formatter would write them, so
`process-sources` is a no-op.
Since `mvn` can't run in my environment, I checked this by porting the wrap
(greedy fill at 120 columns counted from column 0, inline `{@tag ...}` kept
atomic) and calibrating it against unmodified files on `main` until it
reproduced them byte-for-byte. I then ran it over every Java paragraph that
any of my open PRs edits. The other branches came back clean except for two
paragraphs in #29647, which I'm fixing there — thanks for pointing at
`FilesURIStrings` and `QuarkusHelper`, they were exactly the two.
The generated endpoint/component DSL builders flagged by that same check are
a false positive: those carry the generator's own 78-column wrap and the
Eclipse formatter does not run on `src/generated`, which is why their
~80-column Javadoc has survived in `main`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
