Dhairya-007 commented on PR #29647:
URL: https://github.com/apache/camel/pull/29647#issuecomment-6802190643
Thanks — all three addressed.
**1. Formatter.** You identified exactly the two paragraphs. Both are now
wrapped the way the formatter writes them, so `process-sources` is a no-op:
- `FilesURIStrings:41` — the `$` now sits at the end of the previous line.
- `QuarkusHelper:697` — "give the" moved up.
`mvn` isn't available in my environment, so instead of guessing I ported the
wrap (greedy fill at 120 columns counted from column 0, inline `{@tag ...}`
kept atomic) and calibrated it against unmodified files on `main` until it
reproduced them byte-for-byte. I then ran it over every Java paragraph that
any of my open PRs touches. It found two more, both now fixed in their own
PRs — `DefaultComponent` and `SimpleTypeConverter` in #29643, and
`ObjectFactory` in #29644 — so thank you, the same mistake was in three PRs
and your two lines were what led me to the rest.
**2. `findQuarkusPlatformBom`.** `@param download` and `@param fresh` are
added, and the wrong return contract is gone from both the summary and the
`@return`: it returns `null` when there is no compatible platform (the
`resolved.orElse(null)` and the earlier `return null`), and nothing is called
`buildTimeQuarkusVersion`.
**3. `findPlatformBom`.** All three nits taken:
- the example is now `"4.18"`;
- `@return` says "the platform BOM with the closest Camel version, or empty
if
there is none", which is what the `sorted()` over
`CamelVersionInPlatformRelease` then `findFirst()` actually does;
- the block starts with a summary sentence instead of an empty line, naming
`MajorMinor#distanceTo` as the ordering, with an exact match first.
On the overlap with #29643: agreed, the four shared files touch different
lines and merge cleanly. #29643 has since gained two more commits (the
intentional-example revert and the re-wrap), both in `BeanInfo`,
`QuickFixes`, `DefaultComponent` and `SimpleTypeConverter`, so the two still
do not collide.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
