Dhairya-007 commented on PR #29649:
URL: https://github.com/apache/camel/pull/29649#issuecomment-6802321714
Thanks — all three taken.
**1. The lost cause is fixed.** `ApplicationPkcs7MimeCompressedDataEntity:60`
now throws `new HttpException("Failed to create compressed data", e)`, so the
BouncyCastle/CMS failure is no longer swallowed. Worth noting the sibling
`ApplicationPkcs7MimeEnvelopedDataEntity:60` drops its cause the same way —
it is the line this class was copied from — but this PR does not otherwise
touch that file, so I left it. Happy to add it here or in a follow-up,
whichever you prefer.
**2. `"server"` it is.** You're right that it follows this PR's own rule
better: `AS2ConnectionHelper:104` passes `configuration.getServer()` into
that parameter, and `server` is the documented option ("The value included in
the Server message header identifying the AS2 Server"), so the failure now
names what the user would set rather than the constructor parameter.
**3. The leftover parameter name is gone** from
`AbstractThrottler.setMaximumRequestsExpression` and the `Throttler`
interface declaration; both now read `maxRequestsExpression`, matching the
field.
Two references to the old name survive inside `ConcurrentRequestsThrottler`
(a comment at `:333` and a runtime message at `:347`, "The
maxConcurrentRequestsExpression was evaluated as null"). The message names
an identifier that no longer exists anywhere, so it is arguably the same
problem as the rest of this PR — but it is in the concurrent throttler, where
the old name at least reads sensibly, and you didn't ask for it. Say the word
and I'll change the message to name `maximumRequestsExpression`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
