urunni88 commented on PR #29654: URL: https://github.com/apache/camel/pull/29654#issuecomment-6813820951
Thanks for the review, @davsclaus! I pushed a commit for the findings: 1. The response model is now passed to GenAiUsage.of(...) in both paths, and shouldEmitGenAiSpanFromEmbeddingsProducer asserts the gen_ai.response.model tag. 2. removeResultHeaders now also removes RESPONSE_MODEL (this was gnodet-bot's point too). I kept the FINISH_REASON removal, as you suggested. 3. For FINISH_REASON, I'd prefer a follow-up JIRA to deprecate it, so this PR stays focused. I can open it and send a PR for it. 4. An empty embeddings list now fails with an IllegalStateException with a clear message instead of an IndexOutOfBoundsException. 5. The upgrade guide section is moved before the Jackson 3 sections. All 21 tests of the module pass locally. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
