oscerd commented on PR #29630: URL: https://github.com/apache/camel/pull/29630#issuecomment-6819046789
Pushed `CAMEL-26827: Address review feedback - the probe call is bounded as a whole, and the tests read the client through an accessor` (18a89d9604e2) on top of ca8f3d6dc5aa: 1. Both probes now send with `sendAsync` and wait for the whole response, body included, under `TIMEOUT`, cancelling the call on timeout (reported as an `HttpTimeoutException`) or interrupt and unwrapping the `ExecutionException` cause; the existing catch blocks turn these into DOWN as before. 2. One client per health check: yes, one selector thread per enabled check, bounded by the number of checks and released on stop. The ref-counted sharing CAMEL-26827 lists stays a possible follow-up; it is not needed for this fix. 3. The lifecycle tests read the probe's client through a package-private `currentClient()` on both probes, so a rename there is a compile error; the `probe` field of the checks is still read reflectively, since the policy checks live in another package. 4. `HttpClient.shutdownNow()`: 4.24 is Java 21 and later, so it stays; a backport to camel-4.18.x would use the `AutoCloseable` form `OpaHttpClient.close()` uses. The fix version on CAMEL-26827 is for whoever merges. camel-opa module: 121 tests, camel-openfga module: 139 tests, 0 failures. Review re-requested. _Claude Code on behalf of oscerd_ -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
