oscerd commented on PR #29628: URL: https://github.com/apache/camel/pull/29628#issuecomment-6819073502
Pushed `CAMEL-26826: Address review feedback - the stall tests check for the timeout, an Error is rethrown as it is, and the class Javadoc says why the body is buffered` (8d91b8e92e36) on top of ccad82cea6a3: 1. `failsClosedWhenTheResponseBodyStallsAfterHeaders` and `failsClosedWhenTheServerAcceptsAndThenSaysNothing` now assert `hasRootCauseInstanceOf(HttpTimeoutException.class)`; the evaluator keeps the cause, so both pass for the right reason. 2. An `Error` cause of the `ExecutionException` is rethrown as it is instead of being wrapped in an `IOException`. 3. The class Javadoc no longer speaks of a Java 17 baseline, and says why the body is buffered rather than streamed with `ofInputStream`: the request timeout stops at the headers, so the whole response is awaited under `requestTimeout`. 4. The same stall in the health probes is fixed in #29630. camel-opa module: 122 tests, 0 failures. Review re-requested. _Claude Code on behalf of oscerd_ -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
