oscerd commented on PR #29637:
URL: https://github.com/apache/camel/pull/29637#issuecomment-6819077082

   Pushed `CAMEL-26829: Address review feedback - OpaBatchOutcome prints its 
fields and is Serializable, and the docs say how a whole-batch failure is 
reported` (5c7c8a6232b1) on top of 6650a8b180ee:
   
   1. `OpaBatchOutcome.toString()` shows the four fields, so the header reads 
in the tracer, the log component, the message history and the consoles.
   2. `OpaBatchOutcome` is `Serializable` (an enum, a `Boolean` and two 
booleans), so an aggregation repository with `allowSerializedHeaders=true` 
keeps the header.
   3. On the question: a call that never reached OPA and an element whose own 
decision point was unavailable are reported alike, every element `UNAVAILABLE` 
with `failedOpen=true`, because the route proceeds the same way in both cases. 
The Javadoc of `evaluateBatch` and the component page now say so; a distinct 
marker can follow if someone needs to tell the two apart.
   4. The `evaluateBatch` Javadoc mentions `CamelOpaBatchOutcomes` and that 
`CamelOpaDecisionFailedOpen` is set when any element failed open.
   
   The CI failure on this PR is in camel-jbang-core 
(`ExportMainApplicationPropertiesTest`, "expected test but was world"), which 
this PR does not touch; the same job failed on main this morning. camel-opa 
module: 122 tests, 0 failures. Catalog copy of the page updated. Review 
re-requested.
   
   _Claude Code on behalf of oscerd_
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to