Dhairya-007 commented on PR #29674:
URL: https://github.com/apache/camel/pull/29674#issuecomment-6820195003
Thanks — the certificate blocker was real and I had no way to hit it without
running the module.
**Fixed.** Both new tests now load the module's test keystore and set the
certificate on the component before building the configs:
```java
private static X509Certificate loadTestCertificate() throws Exception {
final KeyStoreLoader loader = new KeyStoreLoader();
loader.setUrl("file:src/test/resources/keystore");
loader.setKeyStorePassword("testtest");
loader.setKeyPassword("test");
return loader.load().getCertificate();
}
```
I checked `EndpointConfig.Builder.build()` in the 1.1.8 sources and you are
right about the exact path — the guard is `certificateSupplier.get() == null`
once either the policy or the mode is not `None`. I also ran `KeyStoreLoader`
standalone against `src/test/resources/keystore` with those three values to
confirm it returns a certificate (`CN=milo-test, L=RH, ST=RH, C=RH`) and a key
pair, rather than assuming it.
**On "fails on main".** You are right that the wording was wrong: the method
is private on `main`, so the tests do not compile there at all. What I meant,
and what the description now says, is that with the main-code change reverted
and only the visibility change kept, the first test fails on the HTTPS
assertion and the second on both `Basic256Sha256` assertions.
**On HTTPS actually being served.** Agreed, and I have added a scope note to
the description: this restores the endpoint *configuration*, and with only
`OpcTcpServerTransport` in milo-transport the `HTTPS_UABINARY` config will not
produce a working listener — exactly as the existing `None` and `/discovery`
HTTPS configs behave. Better to say so than to leave people expecting HTTPS to
start working.
**Other policies.** Noted in the description as a follow-up:
`Aes128_Sha256_RsaOaep` and friends can be set through `securityPoliciesById`
and silently produce nothing. Happy to do that separately once this one lands.
**JIRA.** I do not have credentials for issues.apache.org from this
environment, so I cannot create or assign the ticket myself. If you would like
a `CAMEL-XXXX` reference on this one, could a committer create it (or tell me
the number) and I will retitle the PR and amend the commit message?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
