davsclaus commented on code in PR #29774:
URL: https://github.com/apache/camel/pull/29774#discussion_r4560689829
##########
dsl/camel-kamelet-main/src/main/java/org/apache/camel/main/KameletMain.java:
##########
@@ -695,10 +695,15 @@ protected CamelContext createCamelContext() {
String sourceDir =
getInitialProperties().getProperty(getInstanceType() + ".sourceDir");
try {
+ // the dependencies the user gives (CLI, //DEPS, Kamelets): a run
needs them, so it fails when one cannot be
+ // downloaded, while exporting and transforming keep going as far
as they can
+ boolean requiredDependencies = !export && !transform;
Review Comment:
Fixed in b2721f308e16: `KameletRoutesBuilderLoader` no longer ignores what a
`DependencyStrategy` throws, so the strategy decides (required when running,
lenient for export and transform), the same as a `//DEPS` line through
`JBangModelineParser`, which never had that catch.
`DependencyDownloaderStrategyTest` now loads a Kamelet with a missing
dependency (this test fails without the fix) and one whose dependency is
downloaded.
_Claude Code on behalf of Claus Ibsen (davsclaus)_
##########
dsl/camel-kamelet-main/src/main/java/org/apache/camel/main/download/DownloadThreadPool.java:
##########
@@ -78,9 +94,17 @@ void awaitCompletion(Logger log, Future<?> future, String
gav) {
// not done
} catch (InterruptedException e) {
Thread.currentThread().interrupt();
+ future.cancel(true);
Review Comment:
Agreed, added a comment at the `cancel(true)` in b2721f308e16.
_Claude Code on behalf of Claus Ibsen (davsclaus)_
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
