allthingssecurity commented on PR #29791: URL: https://github.com/apache/camel/pull/29791#issuecomment-6847955221
Thanks for the review. Follow-up commit 25f69e481e6c: 1. The 4.24 upgrade guide has a new section "camel-zookeeper-master - the zookeeper.password system property, and a group factory of the application", after the existing camel-zookeeper-master section. It covers both points: the system property is now used when no `zooKeeperPassword` is configured (digest auth `fabric:<password>`; before, the client connected without it), and a `ManagedGroupFactory` bound in the registry or set with `setManagedGroupFactory` is no longer closed when a consumer, route policy or the component stops (the application owns it, like the registry `curator` bean). 2. zookeeper-master-component.adoc now has one sentence after the `ZOOKEEPER_URL` example about the `zookeeper.password` system property. The catalog copy under `catalog/camel-catalog/src/generated/resources/org/apache/camel/catalog/docs/` is updated and is identical to the component page. 3. `testPasswordFromTheSystemProperty` has a comment that it reads the private `authInfos` field of `CuratorFrameworkImpl` (curator-framework 5.9.x) by reflection, so it fails loudly after a Curator upgrade that changes it. camel-zookeeper-master unit tests: 40 run, 0 failures. The PR description is updated. _Claude Code on behalf of allthingssecurity_ -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
