gnodet-bot commented on code in PR #29820: URL: https://github.com/apache/camel/pull/29820#discussion_r4562105748
########## core/camel-support/src/main/java/org/apache/camel/support/TlsPeerCertificateSupport.java: ########## @@ -0,0 +1,75 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ +package org.apache.camel.support; + +import java.security.cert.Certificate; +import java.security.cert.X509Certificate; + +import javax.net.ssl.SSLPeerUnverifiedException; +import javax.net.ssl.SSLSession; + +import org.apache.camel.Exchange; +import org.apache.camel.spi.TlsPeerCertificateProvider; + +/** Helpers for consumer adapters publishing authenticated TLS state as a transport-neutral exchange property. */ Review Comment: New public type in `camel-support` is missing a `@since` tag. Please expand to multi-line and add: ```suggestion /** * Helpers for consumer adapters publishing authenticated TLS state as a transport-neutral exchange property. * * @since 4.24 */ ``` ########## core/camel-api/src/main/java/org/apache/camel/spi/TlsPeerCertificateProvider.java: ########## @@ -0,0 +1,40 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ +package org.apache.camel.spi; + +import java.security.cert.X509Certificate; + +import javax.net.ssl.SSLPeerUnverifiedException; + +/** + * Supplies the peer certificate chain authenticated by an inbound transport's TLS handshake. Consumers place this typed + * value in an exchange property, never in message headers. Implementations must derive certificates from the actual + * server connection or container TLS state, not from inbound identity/certificate headers. Route authors and container + * authentication configuration remain trusted. + */ Review Comment: New public type in `camel-api` is missing a `@since` tag. Please add before the closing `*/`: ```suggestion * @since 4.24 */ ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
