davsclaus opened a new pull request, #29843:
URL: https://github.com/apache/camel/pull/29843
## Description
The SSL setting of the OAI-PMH producer's HTTP client could be set in two
places: the `ignoreSSLWarnings` endpoint option and the
`CamelOaimphIgnoreSSLWarnings` message header. The header is not in the
component documentation or the catalog.
This PR makes the `ignoreSSLWarnings` endpoint option the only way to set it:
- `OAIPMHProducer` sets the HTTP client from
`endpoint.isIgnoreSSLWarnings()` only and no longer reads the header.
- `OAIPMHConstants.IGNORE_SSL_WARNINGS` is removed.
- `CamelOaimphOnlyFirst` stays a per-exchange header (CAMEL-26130).
- The 4.24 upgrade guide entry of CAMEL-26130 is amended: the header is
removed; use the `ignoreSSLWarnings` endpoint option instead, for example on a
separate endpoint URI for the repositories that need it.
## Tests
- New `OAIPMHProducerIgnoreSSLWarningsTest`, against the HTTPS port of
`MockOaipmhServer`:
- `ignoreSSLWarningsHeaderDoesNotChangeTheCertificateCheck`: an exchange
with the header set to `true`, on an endpoint without the option, still rejects
the self-signed certificate.
- `ignoreSSLWarningsEndpointOptionAcceptsTheSelfSignedCertificate`: an
endpoint with `ignoreSSLWarnings=true` harvests from the HTTPS port, also when
an exchange has the header set to `false`.
- `OAIPMHProducerHeadersPerExchangeTest` keeps the `CamelOaimphOnlyFirst`
tests; the two header tests for the removed header moved to the new test in
their new form.
- Both new tests fail without the production change. All 15 tests of
`camel-oaipmh` pass.
JIRA: https://issues.apache.org/jira/browse/CAMEL-26921
_Claude Code on behalf of Claus Ibsen (davsclaus)_
🤖 Generated with [Claude Code](https://claude.com/claude-code)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
