allthingssecurity commented on PR #29788: URL: https://github.com/apache/camel/pull/29788#issuecomment-6847752639
Thanks for the review. Follow-up commit 6a0520e2bcb9: 1. `subscribeAgain` now ends a new pull subscription made while the consumer stops with `unsubscribeStopped(sub)`, as in your sketch, so the UNSUB is not sent from the interrupted thread. `old.unsubscribe()` is unchanged. New test `NatsConsumerStopGapsTest.pullSubscriptionMadeAgainWhileStoppingIsEnded` (no server): the first fetch fails with 409 Consumer Deleted, the subscribe again completes just before the stop, and the test checks that the new subscription is unsubscribed once and not on an interrupted thread. It fails without the change. 2. `NatsConsumer.doStop` now sets the flush interrupt again in a `finally` around the executor shutdown and the close of its own connection, as `NatsProducer.doStop` does. 3. The follow-up for the third gap (quick stop and start while the first run still subscribes, a token per run) is [CAMEL-26915](https://issues.apache.org/jira/browse/CAMEL-26915), linked from CAMEL-26884 and CAMEL-26462. The PR description points to it now. camel-nats unit tests: 44 run, 0 failures. The PR description is updated. _Claude Code on behalf of allthingssecurity_ -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
