gnodet-bot commented on code in PR #29881:
URL: https://github.com/apache/camel/pull/29881#discussion_r4567904744


##########
docs/user-manual/modules/ROOT/pages/camel-4x-upgrade-guide-4_18.adoc:
##########
@@ -806,6 +806,48 @@ The `netty-http` producer no longer sends some of its 
endpoint options, such as
 query parameters that are not endpoint options are sent, as the documentation 
describes. To send a query parameter
 that has the same name as an endpoint option, set the query in the 
`CamelHttpQuery` header.
 
+=== camel-pulsar - the producer no longer replaces the body with the message id
+
+After sending, the producer used to overwrite the message body with the 
`MessageId` returned by the
+broker, so every step after the `to("pulsar:...")` saw a `MessageId` instead 
of the payload, and a route
+such as `.to("pulsar:a").to("pulsar:b")` published a Java-serialized 
`MessageId` to the second topic.
+That behaviour dates from the asynchronous send added in 3.20 (CAMEL-16030).
+
+The body is now left untouched, and the assigned id is reported on the new
+`CamelPulsarProducerMessageId` header instead.
+
+A route that read the `MessageId` from the body must read that header instead.
+
+=== camel-pqc - FileBasedKeyLifecycleManager restricts keyId to a flat file 
name
+
+`FileBasedKeyLifecycleManager` now confines every key file to its configured 
key directory. A `keyId`
+(supplied through the `CamelPQCKeyId` / `CamelPQCNewKeyId` headers) that 
contains a forward slash, a
+backslash, a null character, or that would otherwise resolve outside the key 
directory is now rejected
+with an `IllegalArgumentException`.
+
+Previously a `keyId` such as `tenant-a/signing` resolved into a subdirectory 
of the key directory.
+Deployments that organised keys that way must switch to a flat `keyId` (for 
example `tenant-a-signing`).
+Only the file-based manager is affected; the in-memory and cloud-backed 
managers were never file-path
+based.
+
+=== camel-core - default TLS protocols and cipher suites of 
SSLContextParameters
+
+The default secure socket protocols filter of `SSLContextParameters` now also 
excludes `TLSv1` and `TLSv1.1` (so
+`TLSv1.2` is the minimum), and the default cipher suites filter also excludes 
the `3DES` cipher suites. The default
+filters of an `SSLServerSocket` are now applied over the default (enabled) 
protocols and cipher suites of the JVM, as
+they already were for an `SSLSocket` and `SSLEngine`. Previously they were 
applied over all the supported protocols
+and cipher suites, which enabled `TLSv1` and `TLSv1.1` on a server socket 
(unless disabled in the JVM security
+configuration).
+
+To use an older protocol (not recommended) configure it explicitly using 
`secureSocketProtocols`.

Review Comment:
   🔤 **Nit:** Missing comma after the parenthetical — the sentence reads as an 
imperative starting with "configure" but the parenthetical needs to be set off.
   
   ```suggestion
   To use an older protocol (not recommended), configure it explicitly using 
`secureSocketProtocols`.
   ```



##########
docs/user-manual/modules/ROOT/pages/camel-4x-upgrade-guide-4_22.adoc:
##########
@@ -692,6 +692,71 @@ The `netty-http` producer no longer sends some of its 
endpoint options, such as
 query parameters that are not endpoint options are sent, as the documentation 
describes. To send a query parameter
 that has the same name as an endpoint option, set the query in the 
`CamelHttpQuery` header.
 
+=== camel-pulsar - the producer no longer replaces the body with the message id
+
+After sending, the producer used to overwrite the message body with the 
`MessageId` returned by the
+broker, so every step after the `to("pulsar:...")` saw a `MessageId` instead 
of the payload, and a route
+such as `.to("pulsar:a").to("pulsar:b")` published a Java-serialized 
`MessageId` to the second topic.
+That behaviour dates from the asynchronous send added in 3.20 (CAMEL-16030).
+
+The body is now left untouched, and the assigned id is reported on the new
+`CamelPulsarProducerMessageId` header instead.
+
+A route that read the `MessageId` from the body must read that header instead.
+
+=== camel-pqc - FileBasedKeyLifecycleManager restricts keyId to a flat file 
name
+
+`FileBasedKeyLifecycleManager` now confines every key file to its configured 
key directory. A `keyId`
+(supplied through the `CamelPQCKeyId` / `CamelPQCNewKeyId` headers) that 
contains a forward slash, a
+backslash, a null character, or that would otherwise resolve outside the key 
directory is now rejected
+with an `IllegalArgumentException`.
+
+Previously a `keyId` such as `tenant-a/signing` resolved into a subdirectory 
of the key directory.
+Deployments that organised keys that way must switch to a flat `keyId` (for 
example `tenant-a-signing`).
+Only the file-based manager is affected; the in-memory and cloud-backed 
managers were never file-path
+based.
+
+=== camel-core - default TLS protocols and cipher suites of 
SSLContextParameters
+
+The default secure socket protocols filter of `SSLContextParameters` now also 
excludes `TLSv1` and `TLSv1.1` (so
+`TLSv1.2` is the minimum), and the default cipher suites filter also excludes 
the `3DES` cipher suites. The default
+filters of an `SSLServerSocket` are now applied over the default (enabled) 
protocols and cipher suites of the JVM, as
+they already were for an `SSLSocket` and `SSLEngine`. Previously they were 
applied over all the supported protocols
+and cipher suites, which enabled `TLSv1` and `TLSv1.1` on a server socket 
(unless disabled in the JVM security
+configuration).
+
+To use an older protocol (not recommended) configure it explicitly using 
`secureSocketProtocols`.

Review Comment:
   🔤 **Nit:** Same missing comma after parenthetical (copy of the same 
sentence).
   
   ```suggestion
   To use an older protocol (not recommended), configure it explicitly using 
`secureSocketProtocols`.
   ```



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to