davsclaus commented on code in PR #29876:
URL: https://github.com/apache/camel/pull/29876#discussion_r4572877295
##########
components/camel-cxf/camel-cxf-soap/src/test/java/org/apache/camel/component/cxf/jaxws/CxfProducerTest.java:
##########
@@ -183,7 +200,20 @@ protected String getJaxwsEndpointUri() {
}
protected String getWrongEndpointUri() {
- return "cxf://" + getWrongServerAddress() +
"?serviceClass=org.apache.camel.component.cxf.jaxws.HelloService";
+ // CAMEL-26600: synchronous=true, as with the CXF async client the
callback sometimes never completes
+ // when the connection fails, leaving the exchange waiting forever.
+ // The async error path is not covered here; see CxfClientCallbackTest
and CAMEL-26696.
+ return "cxf://" + getWrongServerAddress()
+ +
"?serviceClass=org.apache.camel.component.cxf.jaxws.HelloService"
+ + "&cxfConfigurer=#wrongServerConfigurer"
Review Comment:
No longer applies. 3a8643d leaves `CxfProducerTest` as it is on
camel-4.22.x: the `#wrongServerConfigurer` endpoint comes from CAMEL-26600,
which is not on this branch, and what #29450 adds to this test is a disabled
async test. The callback is covered by `CxfClientCallbackTest`.
_Claude Code on behalf of davsclaus_
##########
components/camel-cxf/camel-cxf-soap/src/test/java/org/apache/camel/component/cxf/jaxws/CxfProducerTest.java:
##########
@@ -155,6 +156,22 @@ public void testInvokingAWrongServer() throws Exception {
assertInstanceOf(IOException.class, reply.getException().getCause());
}
+ // CAMEL-26696: async producer must always complete the exchange when the
connection fails.
+ // The @Timeout(30s) on the class guards against the exchange hanging in
+ // DefaultAsyncProcessorAwaitManager if camelAsyncCallback.done() is never
called.
Review Comment:
No longer applies. 3a8643d leaves `CxfProducerTest` as it is on
camel-4.22.x, so this comment is gone from the backport.
_Claude Code on behalf of davsclaus_
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
