gnodet-bot commented on code in PR #29920:
URL: https://github.com/apache/camel/pull/29920#discussion_r4573233206
##########
dsl/camel-jbang/camel-jbang-core/src/main/java/org/apache/camel/dsl/jbang/core/commands/CamelJBangMain.java:
##########
@@ -578,6 +579,18 @@ public boolean parseOnly(CamelCommand command) {
/**
* Called after default commands has been added
*/
+ /**
+ * The plugins that this CLI has built in (the Camel launcher embeds
some), and that contribute to the given
+ * command, such as the test plugin, whose exporter adds the Citrus tests
to camel export. The plugins of the plugin
+ * configuration are not among them.
+ *
+ * @param target the command, such as run or export
+ * @return the plugins, none by default
+ */
+ public Collection<Plugin> getEmbeddedPlugins(String target) {
Review Comment:
⚠️ **Javadoc orphaned**: The new method was inserted between the existing
`postAddCommands` Javadoc and the `postAddCommands` method body. Java attaches
the closest preceding `/** */` to the next declaration — `postAddCommands` now
has no documentation.
Move `getEmbeddedPlugins` (and its Javadoc) **after** `postAddCommands` to
restore the original association:
```suggestion
/**
* Called after default commands has been added
*/
public void postAddCommands(CommandTree commandLine, String[] args) {
// noop
}
/**
* The plugins that this CLI has built in (the Camel launcher embeds
some), and that contribute to the given
* command, such as the test plugin, whose exporter adds the Citrus
tests to camel export. The plugins of the plugin
* configuration are not among them.
*
* @param target the command, such as run or export
* @return the plugins, none by default
*/
public Collection<Plugin> getEmbeddedPlugins(String target) {
return List.of();
}
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]