christophd commented on PR #29857:
URL: https://github.com/apache/camel/pull/29857#issuecomment-6881662244

   Thanks for the thorough review @davsclaus! All points addressed in 
160c44290fa2:
   
   **1. camel-test-infra version** — `asScannedDependency` now keeps the 
version for `camel-test-infra-*` artifacts since they're not managed by the 
Camel BOM. Added `shouldKeepVersionForCamelTestInfraArtifacts` test that 
asserts the dependency has 4 colon-separated parts (group:artifact:version 
format).
   
   **2. citrus-http restored as default** — Added back to the defaults list. 
Java tests can't be scanned by `DelegatingCodeAnalyzer`, so they need this as a 
fallback. Also extracted `isTestSource(Path)` to share the filter between 
`addSourceFiles` and `detectDependenciesFromTestSources`, and added 
`isAnalyzerSupported(Path)` to filter to yaml/yml/xml/groovy before calling the 
analyzer. The catch block is now `IOException` only (no longer swallows 
`CitrusRuntimeException`).
   
   **3. Camel-specific mapping tests** — Added 4 new tests:
   - `shouldDetectCamelInfraServiceDependencies` — `service: kafka` → 
`camel-test-infra-kafka`
   - `shouldDetectCamelEndpointDependencies` — `endpoint: 
"camel:kafka:myTopic"` → `camel-kafka`
   - `shouldDetectCitrusHttpFromHttpAction` — `- http: client:` → `citrus-http` 
present
   - `shouldKeepVersionForCamelTestInfraArtifacts` — version preserved for 
test-infra artifacts
   
   **4. Docs** — Updated `camel-jbang-test.adoc` to mention auto-detection from 
YAML/XML/Groovy sources and that `jbang.properties` is still needed for Java 
tests.
   
   **5. isTestSource helper** — Extracted shared predicate, used in both 
methods.
   
   **6. Backslash check** — Moved outside the `org.citrusframework` guard so it 
covers all dependencies.
   
   **7. Citrus-side gaps** — The `service: x` false-positive and the 
`endpoints:` ordering issue are on the Citrus side; will file issues there 
separately.
   
   _Claude Code on behalf of christophd_


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to