gnodet-bot commented on code in PR #29960:
URL: https://github.com/apache/camel/pull/29960#discussion_r4575142893
##########
components/camel-jackson3xml/src/main/java/org/apache/camel/component/jackson3xml/JacksonXMLConstants.java:
##########
@@ -20,6 +20,11 @@ public final class JacksonXMLConstants {
public static final String ENABLE_TYPE_CONVERTER =
"CamelJacksonXmlEnableTypeConverter";
+ /**
+ * @deprecated Duplicate of ENABLE_TYPE_CONVERTER, which holds the same
value and is the name the other Jackson
+ * components use
+ */
+ @Deprecated
Review Comment:
Add `since` to `@Deprecated` and use `{@link}` for IDE navigation to the
replacement. Camel convention uses `@Deprecated(since = "X.Y.Z")`.
```suggestion
/**
* @deprecated Use {@link #ENABLE_TYPE_CONVERTER} instead — this is a
duplicate holding the same value.
*/
@Deprecated(since = "4.24.0")
```
##########
components/camel-jacksonxml/src/main/java/org/apache/camel/component/jacksonxml/JacksonXMLConstants.java:
##########
@@ -20,6 +20,11 @@ public final class JacksonXMLConstants {
public static final String ENABLE_TYPE_CONVERTER =
"CamelJacksonXmlEnableTypeConverter";
+ /**
+ * @deprecated Duplicate of ENABLE_TYPE_CONVERTER, which holds the same
value and is the name the other Jackson
+ * components use
+ */
+ @Deprecated
Review Comment:
Same as the jackson3xml counterpart: add `since` and use `{@link}`.
```suggestion
/**
* @deprecated Use {@link #ENABLE_TYPE_CONVERTER} instead — this is a
duplicate holding the same value.
*/
@Deprecated(since = "4.24.0")
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
