gnodet-bot commented on code in PR #29963:
URL: https://github.com/apache/camel/pull/29963#discussion_r4575161339
##########
components/camel-azure/camel-azure-key-vault/src/main/java/org/apache/camel/component/azure/key/vault/KeyVaultConstants.java:
##########
@@ -23,14 +23,14 @@ public final class KeyVaultConstants {
// headers set by the producer only
@Metadata(label = "producer", description = "Overrides the desired
operation to be used in the producer.",
- javaType =
"org.apache.camel.component.azure.key.vault.KeyVaultOperationDefinition")
+ javaType =
"org.apache.camel.component.azure.key.vault.KeyVaultOperation")
public static final String OPERATION = HEADER_PREFIX + "ProducerOperation";
// headers set by the producer only
@Metadata(label = "producer", description = "The secret name to be used in
Key Vault",
javaType = "String")
public static final String SECRET_NAME = HEADER_PREFIX + "SecretName";
@Metadata(label = "producer", description = "The secret properties to be
used in Key Vault for updating a secret",
Review Comment:
⚠️ **Missing test for runtime fix.** The `String` → `SecretProperties`
mismatch is a behavioural bug: a caller who follows the documented `String`
type gets `null` back from `getHeader(KEY, SecretProperties.class)`, causing
the operation to throw `"secret properties must be specified"` even when the
header is correctly set. Please add a unit test to `KeyVaultProducerTest` that
sets a `SecretProperties` instance on the header and asserts
`updateSecretProperties` succeeds — this would have been red before this fix
and confirms the correction.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
