Dhairya-007 opened a new pull request, #29969:
URL: https://github.com/apache/camel/pull/29969

   ## Problem
   
   Three options in `WorkdayConfiguration` put their own name in `label`:
   
   ```java
   @UriParam(label = "host", description = "Workday Host name.")
   private String host;
   
   @UriParam(label = "tenant", description = "Workday Tenant name.")
   private String tenant;
   
   @UriParam(label = "format", description = "Workday Report as a service 
output format.", enums = "json",
             defaultValue = "json")
   private String reportFormat = "json";
   ```
   
   `label` is a comma-separated set of group tokens, so each string becomes a 
group. `workday.json` ends up with three groups holding one option each - the 
option that named them:
   
   ```
     2 parameter  producer (advanced)   lazyStartProducer
     3 parameter  advanced              httpConnectionManager
     4 parameter  format                reportFormat
     5 parameter  host                  host
     6 parameter  security              clientId
     7 parameter  security              clientSecret
     8 parameter  security              tokenRefresh
     9 parameter  tenant                tenant
   ```
   
   So the component's option table has a "Format" section with `reportFormat` 
in it, a "Host" section with `host`, and a "Tenant" section with `tenant`, and 
filtering the catalog by `common` returns nothing for this component although 
these are its main settings. The same class gets it right for the rest - 
`security` on the three credentials and `advanced` on `httpConnectionManager`.
   
   ## Fix
   
   Label all three `common`. They are plain connection and output settings of a 
producer-only component, and `common` is the group an option with no label of 
its own lands in.
   
   After this:
   
   ```
     2 parameter  common                host
     3 parameter  common                reportFormat
     4 parameter  common                tenant
     5 parameter  producer (advanced)   lazyStartProducer
     6 parameter  advanced              httpConnectionManager
     7 parameter  security              clientId
     8 parameter  security              clientSecret
     9 parameter  security              tokenRefresh
   ```
   
   No option is renamed and no behaviour changes - only where the docs file 
them. The regenerated `workday.json` files are included, produced by 
`camel-package-maven-plugin` rather than edited by hand.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to