gnodet-bot commented on code in PR #29954: URL: https://github.com/apache/camel/pull/29954#discussion_r4575248988
########## docs/user-manual/modules/ROOT/pages/camel-4x-upgrade-guide-4_24.adoc: ########## @@ -8743,3 +8743,14 @@ if it configured the proxy. It is now deprecated, with a `deprecationNote` that says so, and its description no longer claims to configure a proxy. Remove `protocol` from the endpoint URI or the configuration. To send the client's traffic through a proxy, use `proxyProtocol` together with `proxyHost` and `proxyPort`, which the shared client builder does apply. + +=== camel-docker - the loggingFilter and followRedirectFilter options are deprecated + +Neither option has ever had an effect. `DockerClientFactory` builds the whole `DockerClientProfile` that the client is Review Comment: ⚠️ **Historically inaccurate:** These options *did* work in Camel 2.17 (`DockerClientFactory` called `configBuilder.withLoggingFilter(...)` / `withFollowRedirectsFilter(...)`). The docker-java 3.x migration in Camel 2.18 removed them. As davsclaus noted, please update to something like: ```suggestion Neither option has had any effect since Camel 2.18. `DockerClientFactory` builds the whole `DockerClientProfile` that the client is ``` ########## docs/user-manual/modules/ROOT/pages/camel-4x-upgrade-guide-4_24.adoc: ########## @@ -8743,3 +8743,14 @@ if it configured the proxy. It is now deprecated, with a `deprecationNote` that says so, and its description no longer claims to configure a proxy. Remove `protocol` from the endpoint URI or the configuration. To send the client's traffic through a proxy, use `proxyProtocol` together with `proxyHost` and `proxyPort`, which the shared client builder does apply. + +=== camel-docker - the loggingFilter and followRedirectFilter options are deprecated + +Neither option has ever had an effect. `DockerClientFactory` builds the whole `DockerClientProfile` that the client is +created from, and it sets neither of them - `DockerClientProfile` has no field for either - so `isLoggingFilter()` and +`isFollowRedirectFilter()` are called only by the generated configurers. The two matching headers, +`CamelDockerLoggingFilter` and `CamelDockerFollowRedirectFilter`, are read nowhere either. + +Both options and both header constants are now deprecated. Remove `loggingFilter` and `followRedirectFilter` from the +endpoint URI or the component configuration; setting them changed nothing. To log the exchanges with the Docker daemon, +use a `log` EIP or raise the log level of the docker-java client instead. Review Comment: ⚠️ **Incorrect logging advice:** A Camel `log` EIP traces the Camel exchange — it does not capture Docker daemon protocol traffic. As davsclaus noted, the only actionable guidance is raising the log level of the `com.github.dockerjava` loggers. ```suggestion Raise the log level of the `com.github.dockerjava` loggers to see the daemon traffic. ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
