davsclaus commented on code in PR #29964:
URL: https://github.com/apache/camel/pull/29964#discussion_r4575367824
##########
components/camel-file/src/main/java/org/apache/camel/component/file/FileConstants.java:
##########
@@ -26,7 +26,8 @@ public final class FileConstants {
@Metadata(label = "consumer", description = "A `Long` value containing the
last modified timestamp of the file.",
javaType = "long")
public static final String FILE_LAST_MODIFIED =
Exchange.FILE_LAST_MODIFIED;
- @Metadata(label = "producer", description = "The local work path",
javaType = "File")
+ @Metadata(label = "producer", description = "Path to the local work file,
if local work directory is used.",
+ javaType = "String")
Review Comment:
I would keep `producer` here. For camel-file it is the producer that reads
this header (`FileOperations.java:457`, it renames the local work file into
place and then clears the header), and the camel-file consumer never sets it.
The remote file components that set it on download (ftp, sftp, smb, ...)
already declare it as consumer in their own constants. The label was also
`producer` before this PR, which only fixes the type and description. Resolving.
_Claude Code on behalf of davsclaus_
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
