Dhairya-007 opened a new pull request, #29987:
URL: https://github.com/apache/camel/pull/29987
## Problem
Both components build their no-reply logger from this option in the producer
as well as the consumer.
camel-netty:
```java
// NettyProducer
this.noReplyLogger = new CamelLogger(LOG,
configuration.getNoReplyLogLevel());
// ServerChannelHandler, the consumer side
this.noReplyLogger = new CamelLogger(LOG,
consumer.getConfiguration().getNoReplyLogLevel());
```
camel-mina, the same pair in `MinaProducer` and `MinaConsumer`:
```java
this.noReplyLogger = new CamelLogger(LOG,
configuration.getNoReplyLogLevel());
```
The option is nevertheless labelled `consumer,advanced` in both, and each
description names the consumer class as the only thing it affects:
```java
@UriParam(label = "consumer,advanced", defaultValue = "WARN", enums =
"TRACE,DEBUG,INFO,WARN,ERROR,OFF",
description = "If sync is enabled this option dictates
NettyConsumer which logging level to use when logging a there is no reply to
send back.")
private LoggingLevel noReplyLogLevel = LoggingLevel.WARN;
```
```java
/**
* If sync is enabled this option dictates MinaConsumer which logging level
to use when logging a there is no reply
* to send back.
*/
```
So a producer doing request/reply over netty or mina, which is exactly the
case where a missing reply gets logged, finds the option that sets that log
level documented for the other side and named after a class it does not use. In
`MinaConfiguration` it sits directly below `disconnectOnNoReply`, which is
`label = "advanced"` with no side - the two options are about the same
situation.
## Fix
Label it `advanced` in both components, and describe it without naming a
side:
> If sync is enabled this option dictates the logging level to use when
logging that there is no reply to send back.
That also drops the stray "a" the sentence carried in both ("logging a there
is no reply").
Nothing in the runtime path changes - both producers already read it. The
regenerated `netty.json` and `mina.json` files are included, produced by
`camel-package-maven-plugin`; the option moves from the `consumer (advanced)`
group to `advanced`, and the rest of each diff is the index renumbering that
follows.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
