Croway commented on PR #29989:
URL: https://github.com/apache/camel/pull/29989#issuecomment-6884483463
Thanks Claus. All three are in:
1. `securitySaysWhenTheAdvisoryDataIsUnavailable` in
`DependencyCheckToolsTest` (aedce6d3e2f5), with your test plus a check that the
rest of the answer is still there.
2. With routes given and none of the vulnerable artifacts used, the detail
is now "None of them is used by the routes; they are lower priority but should
still be evaluated."; when only some are used, "N of them are used by the
routes (reachable): patch those first. The others are lower priority but should
still be evaluated." (aedce6d3e2f5).
3. `camel_error_diagnose` is removed from both servers (33c8306798eb): the
tool in `AuthoringTools`, `ErrorDiagnoser`, `DiagnoseTools` and
`DiagnoseToolsTest`, the diagnose cases of `AuthoringToolsTest`,
`RepeatedToolCallsTest` and `SourceValidatorResourceLiteralTest`, the mentions
in `camel-jbang-mcp.adoc` (the intro too, in aedce6d3e2f5),
`camel-jbang-tui-ai-agents.adoc` and `design/good-to-know.adoc`, and the
upgrade-guide list. Two differences from your list:
- The two `DiagnoseData` classes stay: `DiagnoseResources` serves them as
the `camel://error/exception-catalog` and `camel://error/exception/{name}`
resources of `camel mcp`, which are not in the tool list. I can remove the
resources and `DiagnoseData` too, in this PR or a follow-up, if you want the
table gone.
- `AiPanelPromptBudgetTest` only names the tool in the comments that say
why the budgets were raised; the budgets are upper bounds and keep passing
(camel-jbang-plugin-tui: 2577 tests green), so I left it.
- `RepeatedToolCallsTest` used the tool as the deterministic tool without
a repeat hint; every remaining one has a hint, so that case now uses a tool of
the test.
The branch is rebased on main. The PR description is updated.
_Claude Code on behalf of Croway_
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
