Dhairya-007 commented on PR #29975:
URL: https://github.com/apache/camel/pull/29975#issuecomment-6892427644

   You are right, thanks — fixed in the new commit.
   
   `determineBucketName` only ever looks at 
`CamelGoogleCloudStorageOverrideBucketName` and then falls back to 
`getConfiguration().getBucketName()`, so `CamelGoogleCloudStorageBucketName` is 
purely a consumer output: set at `GoogleCloudStorageConsumer:443` and read back 
in `processCommit` for the move and delete paths. I had generalised from "the 
consumer sets it" to "both sides use it" without checking the producer's read 
side.
   
   It is now `label = "consumer"` with `description = "The name of the bucket 
the object was consumed from"`, and I updated the two JSON files plus the 
header javadoc in `GoogleCloudStorageEndpointBuilderFactory`. Title and 
description now say 13 headers, with a paragraph recording why `BUCKET_NAME` is 
the exception.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to