allthingssecurity commented on PR #29993:
URL: https://github.com/apache/camel/pull/29993#issuecomment-6894097664

   Thanks @davsclaus (and gnodet for the two notes). Pushed d106111e2629 on top 
of your rebase:
   
   1. **Invariant name**: `dst.check` now uses the same string as `@DstWorld`, 
"every record is routed once the faults cleared, apart from records skipped by 
a LATEST iterator". The component JSON and its catalog copy already carried 
that name; they are regenerated for the `issues` change below and are 
byte-identical.
   2. **CAMEL-26968**: named in the world Javadoc (the paragraph on the excused 
LATEST skip), in the comment in `FakeKinesis.getShardIterator`, and in `issues` 
of `@DstWorld` (`CAMEL-25569`, `CAMEL-25942`, `CAMEL-26968`), so the catalog 
JSON and the table of the camel-test-dst page (and its catalog copy) list it 
too. The PR body now links it.
   
   Optional points:
   - **Second routing keyed on a recorded failure**: done. `Rec` has a `failed` 
count, set where the injected processing failure is thrown, and the excuse for 
a second routing after the checkpoint needs `r.failed > 0 && r.completed == 0`, 
as in the Kafka world.
   - **`finisher` Javadoc**: done; it says the finisher only sets `finished` 
and that the run then stops the CamelContext.
   - **test-dst.adoc, "Running the tests"**: done; 
`KINESIS=components/camel-aws/camel-aws2-kinesis` is in the `-pl` lists, the 
self-check commits 043ac9ec84ab (CAMEL-25569) and 847ee9affb4c (CAMEL-25942) 
are listed with the other worlds' past fixes, and `dst.kinesis.strictLatest` 
with the world-specific properties.
   
   From gnodet's review: the "Not modelled" paragraph of `FakeKinesis` now says 
AT_TIMESTAMP is modelled in GetShardIterator but not configured by the world, 
and the resume cache sorts its keys with 
`Comparator.comparing(Object::toString)`.
   
   Tests on the new head:
   - the Kinesis tests of the module: 1063 run (63, plus 1000 seeds), 0 
failures;
   - 5000 seeds: 0 failing;
   - self-check: with the main code of 043ac9ec84ab (CAMEL-25569) reverted 305 
of 2000 seeds fail, with the main code of 847ee9affb4c (CAMEL-25942) reverted 
710 of 2000 fail, as before the change (so keying the excuse on a recorded 
failure did not hide anything, and did not make main fail).
   
   _Claude Code on behalf of allthingssecurity_
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to