gnodet-bot commented on code in PR #29904:
URL: https://github.com/apache/camel/pull/29904#discussion_r4578329197
##########
design/cli-short-commands.adoc:
##########
@@ -38,8 +40,11 @@ against 10-40 ms estimated), for a fraction of the build and
release work.
The seconds a daemon saves are small next to the turns of the model. The
reason to build it is that a command that
answers at once can be called after every step. An agent makes fewer mistakes
when it validates after every edit, looks
an option up with `camel doc` instead of guessing it, and checks `camel
status` after every reload. Speed alone
-does not make an agent do that, it has to be told (see the motivation), but
speed makes it cheap to do. With the Java
-client the daemon answers in 50-65 ms, under the 0.1 s at which a response
feels instant, like a native command.
+does not make an agent do that, and telling it to is not enough. In a
benchmark with a local model, an instruction to
+check made the model read more, but it checked none of the code it wrote (see
the motivation). The checks have to run
Review Comment:
⚠️ **Sentence too long (~28 words):** This sentence joins two independent
clauses with `but`. Split at `read more`:
> In a benchmark with a local model, an instruction to check made the model
read more. It checked none of the code it wrote (see the motivation).
The line wraps across lines 43–44, so the reflow affects both lines — a
suggestion block would clobber unrelated text. Apply the split manually.
##########
design/cli-short-commands.adoc:
##########
@@ -326,15 +356,23 @@ daemon or a native front does not serve too, and the
start of the daemon itself.
readiness pushed over the WebSocket transport.
. Keep the Java client. At 50-65 ms it answers under the 0.1 s at which a
response feels instant, so the commands
already feel native. A native client for the main platforms, with the Java
client as the fallback, is optional.
-. Tell the agents. Speed alone does not change how an agent uses the CLI, so
what agents read (the Camel CLI pages,
- the instructions of the MCP server, the system prompt of the AI panel) says
that the short commands are cheap to
- call: look an option up instead of guessing it, asking only for the options
needed (the `optionsFilter` of
- `camel_catalog_doc`) as a whole doc page costs context, and validate every
snippet before answering.
+. Tell the agents, and check for them. Speed alone does not change how an
agent uses the CLI. The Camel CLI pages,
+ the MCP server's instructions and the AI panel's system prompt say that the
short commands are cheap to call. They
+ tell an agent to look an option up instead of guessing it. They also tell it
to ask only for the options it needs
+ (the `optionsFilter` of `camel_catalog_doc`), since a whole doc page costs
context. Telling is not enough for the
+ checks: told to validate every snippet, the local model wrote more code and
validated none of it (see the
Review Comment:
⚠️ **Sentence too long (~26 words):** The colon joins two independent
clauses. Replace it with a period:
```suggestion
checks. Told to validate every snippet, the local model wrote more code
and validated none of it (see the
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]