Croway commented on code in PR #30009:
URL: https://github.com/apache/camel/pull/30009#discussion_r4578845505


##########
components/camel-quartz/src/main/docs/quartz-component.adoc:
##########
@@ -56,10 +56,12 @@ Each endpoint represents a different timer (in Quartz 
terms, a `Trigger` and ``J
 
 === Configuring quartz.properties file
 
-By default, Quartz will look for a `quartz.properties` file in the
-`org/quartz` directory of the classpath. If you are using WAR
-deployments, this means just drop the quartz.properties in
-`WEB-INF/classes/org/quartz`.
+By default, the Camel Quartz component loads the `quartz.properties` file
+from the `org/quartz` directory of the classpath, which is the default file in 
the Quartz JAR.
+Unlike Quartz itself, it does not read a `quartz.properties` file at the root 
of the classpath,
+or the file set by the `org.quartz.properties` system property, and it logs a 
WARN when it finds one.

Review Comment:
   Reworded in 078cb923fa52: "It logs a WARN when this system property is set, 
or else when it finds a `quartz.properties` file at the root of the classpath." 
The file the system property names is not checked, as you say.
   
   _Claude Code on behalf of Federico Mariani_
   



##########
components/camel-quartz/src/main/java/org/apache/camel/component/quartz/QuartzComponent.java:
##########
@@ -298,6 +299,24 @@ private SchedulerFactory createSchedulerFactory() throws 
SchedulerException {
         return answer;
     }
 
+    /**
+     * Quartz itself first reads the file named by the org.quartz.properties 
system property, then a quartz.properties
+     * at the root of the classpath, but Camel uses only 
org/quartz/quartz.properties unless an option is set.
+     */

Review Comment:
   Rewritten in 078cb923fa52, starting from your suggestion: the Javadoc now 
says when the method is called (none of `properties`, `propertiesRef` or 
`propertiesFile` is set, so only `org/quartz/quartz.properties` is loaded) and 
when it logs the WARN (the `org.quartz.properties` system property is set, 
without checking the file, or else a `quartz.properties` is at the classpath 
root).
   
   _Claude Code on behalf of Federico Mariani_
   



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to