Croway opened a new pull request, #30047:
URL: https://github.com/apache/camel/pull/30047

   Follow-up of #30006 (CAMEL-26977). These are the review points of that PR. 
#30006 was merged before this commit reached it.
   
   - `idempotentEager` is turned off only when an idempotent read lock really 
runs. With a custom `processStrategy`, the `readLock` option is not used, so 
`idempotentEager` applies as configured. The idempotent read-lock names live in 
one constant.
   - The `idempotentEager` description says that it does not apply with an 
idempotent read lock. The option is shared by file, ftp, ftps, sftp, mina-sftp, 
smb and azure-files, so their JSON, catalog copies and endpoint DSL are 
regenerated.
   - The #30006 note is added to the upgrade guides on main, under 4.22.2 → 
4.22.3 and 4.18.5 → 4.18.6. CAMEL-26977 has those fix versions.
   
   Test: 
`FileIdempotentReadLockIdempotentConsumerTest#customProcessStrategyKeepsIdempotentEager`
 (true/false). The `true` case fails without the `processStrategy` check. The 
camel-core `File*Idempotent*` and `File*ReadLock*` tests pass: 56 run, 0 
failures.
   
   _Claude Code on behalf of Federico Mariani_
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to