Dhairya-007 opened a new pull request, #30079:
URL: https://github.com/apache/camel/pull/30079
## Problem
7 of the component's header `javaType` values name their class by simple
name only:
```java
@Metadata(label = "consumer", description = "The datetime at which the
message was enqueued in Azure Service Bus.",
javaType = "OffsetDateTime")
public static final String ENQUEUED_TIME = HEADER_PREFIX + "EnqueuedTime";
```
```json
"CamelAzureServiceBusEnqueuedTime": { ..., "javaType": "OffsetDateTime", ...
}
```
Fully qualified is the convention by a wide margin - across the whole
catalog, 3692 header `javaType` values are fully qualified or a built-in type,
and 151 are not.
The same file already qualifies other types, so the two spellings sit side
by side - which is what makes these seven look like an oversight rather than a
house style.
`AmqpAnnotatedMessage` (`com.azure.core.amqp.models`) and
`ServiceBusTransactionContext` (`com.azure.messaging.servicebus`) come from two
different Azure artifacts, and `OffsetDateTime` and `Duration` are `java.time`.
## Fix
Qualify all 7, taking each FQN from the import the module itself uses.
Header names are untouched.
Metadata only - no behaviour change. I diffed the regenerated catalog file
against `main` and confirmed the 7 `javaType` values are the only fields that
differ.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]