Dhairya-007 opened a new pull request, #30091:
URL: https://github.com/apache/camel/pull/30091

   ## Problem
   
   The tags header qualifies its container but not its element type:
   
   ```java
   @Metadata(description = "Tags of the metrics", javaType = 
"java.lang.Iterable<Tag>")
   public static final String HEADER_METRIC_TAGS = HEADER_PREFIX + "Tags";
   ```
   
   ```json
   "CamelMetricsTags": { ..., "javaType": "java.lang.Iterable<Tag>", ... }
   ```
   
   `java.lang.Iterable` is spelled out - unusually thoroughly, since most of 
the catalog leaves `Iterable`, `List` and `Map` bare - while `Tag`, the one 
name a reader actually needs, is left short. It is 
`io.micrometer.core.instrument.Tag`, and `Tag` is a heavily reused simple name: 
this repo alone has AWS SDK `Tag` classes in `camel-aws2-ec2` and 
`camel-aws2-eventbridge` header types.
   
   Fully qualified is the convention by a wide margin across the catalog: 3692 
header `javaType` values are fully qualified or a built-in type, and 151 are 
not.
   
   ## Fix
   
   Qualify the element type to 
`java.lang.Iterable<io.micrometer.core.instrument.Tag>`, the FQN the 
component's own sources import. The header name is untouched.
   
   Metadata only - no behaviour change. I diffed the regenerated catalog file 
against `main` and confirmed this one `javaType` value is the only field that 
differs.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to