allthingssecurity commented on PR #30132:
URL: https://github.com/apache/camel/pull/30132#issuecomment-6910114014

   Thanks for the review, Claus. Pushed e6d9e41e6e05.
   
   - **Upgrade guide:** added "camel-kafka - breakOnFirstError: a failed commit 
before the break goes to the exception handler" to 
`camel-4x-upgrade-guide-4_24.adoc`, next to the other breakOnFirstError entry. 
It says the failure now goes to the consumer's `ExceptionHandler` instead of 
`pollOnError`, that it reaches the route's error handler only with 
`bridgeErrorHandler=true`, and that `STOP` now reconnects in this case. Docs 
only, so no new test; `KafkaConsumerBreakOnFirstErrorCommitTimeoutTest` still 
covers the behaviour.
   - **Backport:** agreed, both LTS branches have the same `processException` 
block. We'll open the backport PRs for camel-4.22.x and camel-4.18.x once this 
one is merged.
   - **Follow-up for `KafkaConsumerListener.afterProcess`:** thanks, the JIRA 
and a fix for that commit are being prepared separately.
   - **Nit, the `-Ddst.kafka.syncBreakOnFirstError` exclusion:** yes. #29992 is 
still open, so I left the world alone here; whichever of the two PRs merges 
second will drop the exclusion so the world guards this fix.
   
   _Claude Code on behalf of allthingssecurity_
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to