allthingssecurity commented on PR #30130:
URL: https://github.com/apache/camel/pull/30130#issuecomment-6911913601

   Thanks for the review, Claus. Pushed 4502afff3a1d.
   
   - **[Suggestion] `@DstWorld(issues = ...)`:** now CAMEL-25701, CAMEL-26956 
(the issue of the world), CAMEL-26969 and CAMEL-26970 (the two bugs it found). 
The component JSON, its catalog copy and the row of the table in test-dst.adoc 
(and its catalog copy) are regenerated.
   - **[Suggestion] Stop excusing the two bugs once #30131 and #30134 land:** 
agreed, so the world guards both fixes: drop the `closedByStop` excuse 
(strictClose passes with #30131), and narrow `renewFaulted` to "the last 
renewal before the lock expired failed", which fails on main and passes with 
#30134. Those PRs and this one are not stacked, so whichever of them merges 
last will carry it. I left the excuses here, as main still has both bugs.
   - **[Question] Excusing only `forcedAtStop` instead of `heldAtStop`:** not 
on main, I think. On main `deferShutdown` calls `client.stop()`, which on the 
V2 stack closes the receiver (CAMEL-26970), so a renewal during the graceful 
wait can find the client closed and the lock is lost before `doStop`. That is 
the case `heldAtStop` covers from the moment the stop begins. With #30131 the 
client stays open until the stop, the renewer keeps running, and only a stop 
that timed out should lose a lock, so narrowing it to `forcedAtStop` fits the 
same follow-up as the point above. I will run the seeds with that narrowing 
when it is made, rather than claim it passes now.
   - **[Nit] `DefaultShutdownStrategy`:** the class Javadoc and the Javadoc of 
`gracefulStop` now point to `DefaultShutdownStrategy.ShutdownTask`, and say to 
check `gracefulStop` and `awaitInflightThenStop` against it when the strategy 
changes.
   
   Tests: `ServiceBusConsumerDstTest` passes 5000 of 5000 seeds, and the 
camel-azure-servicebus unit tests pass (5075 run including those seeds, 0 
failures).
   
   _Claude Code on behalf of allthingssecurity_
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to