Croway opened a new pull request, #30175:
URL: https://github.com/apache/camel/pull/30175

   JIRA: [CAMEL-27023](https://issues.apache.org/jira/browse/CAMEL-27023)
   
   - In the Java DSL, `completionSize`, `completionTimeout` and 
`completionPredicate` of the Aggregate EIP, and `handled`, `continued` and 
`retryWhile` of `onException`, wrapped the expression builder 
(`simple("{{size}}")`) in a plain `ExpressionDefinition`. Copying the route 
kept the same builder, so every route created from a route template shared one 
expression, built with the parameters of the first route.
   - `ExpressionSubElementDefinition(Expression)` and `(Predicate)` now unwrap 
the builder with `ExpressionNodeHelper.toExpressionDefinition`, as 
`ExpressionNode` (filter, setBody, when ...) already does. Each templated route 
gets its own copy of the expression.
   - Side effect: route dumps (XML/YAML) and the aggregator JMX attributes now 
show the language and text of these options. Before, the dump was an empty 
`<expressionDefinition/>`.
   
   Tests: `RouteTemplateExpressionOptionPerRouteTest` (camel-core), 7 tests: 
completionSize, completionPredicate, completionTimeout, onException retryWhile 
and handled with two routes from one template, plus the template model. On main 
6 fail (route b uses the value of route a, and the template model has no 
language); the `completionSize("{{size}}")` String control passes. With the fix 
7 pass. Also run with the fix: camel-core `RouteTemplate*`, `Aggregate*`, 
`Aggregator*`, `OnException*`, `Retry*`, `*RetryWhile*`, `ExceptionBuilder*`, 
`DumpModelAs*`, `AsPredicateModelTest`, `Switch*`, 
`DefaultRouteTopologyDumper*`, `ErrorHandler*` (600 tests, 3 skipped, all 
pass), camel-management `ManagedAggregate*`, `ManagedOnException*`, 
`ManagedRouteDump*` (12 tests).
   
   Upgrade guide: entry in `camel-4x-upgrade-guide-4_24.adoc`.
   
   _Claude Code on behalf of Federico Mariani_
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to