oscerd commented on PR #29835: URL: https://github.com/apache/camel/pull/29835#issuecomment-6912254130
Pushed `CAMEL-26839: Keep the design doc to the decision, discard a lease in a finally, keep instances on undefined decisions, and move the doc section` (da27455b794b): - **Design doc**: trimmed to the front matter (now with an author), the Decision, the SDK and ABI evidence and the correctness coverage; the smoke measurements, the reproduction commands and the raw CSV moved into this PR's description (see below), and a short section points there. `status: implemented` stays, as you said. - **`parent/pom.xml`**: a comment at `opa-wasm-version` says to run the camel-opa ITs with `-Pit` after a bump, since they pin the SDK contract. - **`broken.discard()`** is in a `finally` (gnodet-bot thread). - **Undefined decisions no longer discard the instance**: `evaluateDecision` serializes the input before borrowing, evaluates, returns the lease, and only then unwraps; only an exception from the SDK call discards. A rule that is often undefined no longer churns instances that now cost a full data parse. - **Docs**: `=== Static data in pooled WASM instances` moved from Security notes to the end of Evaluation modes; catalog copy regenerated. - **Imports** instead of FQCNs in `OpaWasmStaticDataIT` and `OpaWasmStaticDataBenchmark`. `OpaWasmStaticDataIT` (real compiled WASM through the OPA container) and the unit tests pass locally. #29831 moves its section to the same place, so the second of the two to merge gets a rebase. _Claude Code on behalf of oscerd_ -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
