oscerd commented on PR #29831:
URL: https://github.com/apache/camel/pull/29831#issuecomment-6912270561

   Pushed `CAMEL-26836: One validation for WASM options, a poll that survives 
errors and skips known-bad content, a status that keeps the last failure, and a 
route-level reload test` (ee79270c6b38):
   
   - **`create` duplication**: the `policyBundle`/`poolSize` checks live once 
in `OpaWasmEvaluator.validateWasmOptions`, with the `opa build` hint, and both 
`create` methods call it; the comment in `OpaSecurityPolicyWasmTest` says so.
   - **`poll`** catches `Throwable`, so an `Error` in one run no longer cancels 
the scheduler silently; it logs the failure type like an exception.
   - **Known-bad content** is not rebuilt on every poll: the revision that 
failed is remembered and a poll skips it (DEBUG) until the content changes, so 
a broken file logs one WARN; an explicit `reloadPolicy()` always tries.
   - **Status**: `lastSuccessfulReload` is now `getLastSuccessfulCheck()`, 
since it moves on unchanged polls too, and the last failure time and type are 
kept after later successful checks instead of being reset; all getters, 
`startWatching()`, `stopWatching()` and `OpaEndpoint.getPolicyReloadStatus()` 
have Javadoc (the six gnodet-bot threads). The doc paragraph on the status says 
the same.
   - **Docs**: `=== Reloading a WASM policy` moved from Security notes to the 
end of Evaluation modes; catalog copy regenerated.
   - **Route-level test**: 
`OpaWasmIT.reloadsThroughTheEndpointAndPolicyOptionsWhenTheBundleFileChanges` 
starts an endpoint route and an `OpaSecurityPolicy` route with 
`policyReloadInterval=200`, renames a bundle with changed data over the 
configured file and waits with Awaitility until both decide with the new 
revision.
   - **Imports** instead of FQCNs in `OpaReloadableWasmEvaluatorTest` and 
`OpaWasmIT`.
   - Not changed: the `state` monitor on the hot path (fine for now, as you 
say) and the inputExpression hand-over, which is #29832's rebase concern.
   
   `OpaWasmIT` (real compiled WASM through the OPA container) and the unit 
tests pass locally. #29835 moves its section to the same place, so the second 
of the two to merge gets a rebase.
   
   _Claude Code on behalf of oscerd_
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to