oscerd opened a new pull request, #180:
URL: https://github.com/apache/camel-kit/pull/180

   Closes #122.
   
   Two shipped guides stated that Forage environment variables and system 
properties can only address the default-bean key form and cannot target a named 
bean's key (`forage.myDb.jdbc.url`), steering generated deployment and CI 
guidance toward properties-file edits that are not needed.
   
   ## What changed
   
   - `skills/shared/forage.md`, *Configuration precedence*: both override 
channels address default and named beans alike. A named bean's 
`forage.myDb.jdbc.url` is overridden by `FORAGE_MYDB_JDBC_URL` or 
`-Dforage.myDb.jdbc.url=...`; the variable form is the key upper-cased with `.` 
replaced by `_` (`FORAGE_<NAME>_<DOMAIN>_<PROP>`). The precedence environment > 
system properties > properties files > defaults is unchanged.
   - `skills/camel-test/guides/test-configuration.md`, *Forage override 
channels*: the same correction for CI; the `forage.myDb.jdbc.*` test-profile 
lines are described as the properties-file form of the same override.
   - `ResourceConsistencyTest.forageGuidesDescribeNamedBeanOverrideChannels` 
pins the named forms in both guides and rejects the old restriction.
   - CHANGELOG entry under *Fixed*.
   
   The wording follows `docs/modules/ROOT/pages/forage.adoc`, which already 
described the verified behaviour, so no website change is needed.
   
   ## Verification of the claim
   
   Forage `v1.6.1` (`core/forage-core-common`, the version 
`distribution.properties` maps to Camel 4.22.1): 
`ConfigModule.buildPrefixedName()` returns `forage.<prefix>.<rest>` for a named 
module, `envName()` upper-cases it with `.` replaced by `_`, and 
`ConfigStore.tryRead()` checks `System.getenv(envName)`, then 
`System.getProperty(propertyName)`, then the resolver chain, first non-empty 
value wins, with no distinction between default and named modules. This matches 
the JVM probe recorded in the issue.
   
   ## Verification
   
   - `ResourceConsistencyTest`, `BeanConstructionGuidanceTest` and 
`ShippedAssetStructureTest` pass; `./mvnw -B -Psourcecheck validate` passes.
   - Full reactor `./mvnw clean install -B` with tests: BUILD SUCCESS for all 
13 modules, run with `LC_ALL=C` because the pre-existing 
`LocalCommandRunnerTest.boundsGitDiscoveryToTheWorkingDirectory` asserts on 
git's English stderr text and fails under this machine's Italian locale 
(unrelated to this change; see #176 for the same note).
   
   Website impact: not required (the Forage documentation page already 
describes this behaviour).
   
   _AI-generated by Claude Code (Claude Fable 5.1) on behalf of @oscerd._
   
   🤖 Generated with [Claude Code](https://claude.com/claude-code)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

  • [PR] Fix #122: describe Forag... oscerd (via GitHub) via commits

Reply via email to