oscerd commented on PR #29821:
URL: https://github.com/apache/camel/pull/29821#issuecomment-6912516265

   Rebased on `main` (the generated `spiffe.json` and the endpoint DSL were 
regenerated) and pushed `CAMEL-26833: The readiness check reports the state of 
the watch, not a connection it cannot see, and names its check after the 
endpoint` (a2445aca7563):
   
   - **Must fix, `connection` semantics**: the detail is now `spiffe.watch` 
with the states `not-started`, `starting`, `watching`, `failed` and `stopped`. 
`failed` is set only on `onError`, which java-spiffe 0.8.17 calls for an error 
it does not retry, after which the SDK delivers nothing more; the message says 
the route has to be restarted. The docs now say the check measures whether the 
last delivered identity is valid and not about to expire, that the SDK 
reconnects to an unreachable agent on its own with unlimited retries and 
without telling the watch, so an outage shows up only as an SVID that is no 
longer refreshed and comes within the threshold, and that `materialValid` keeps 
describing the retained material. The recovery test no longer relies on an 
update after `onError`: 
`failedWatchStaysDownAndRetainsMaterialMetadataWithoutPublishingFailureDetails` 
checks the failed state, the retained details, the absence of exception text, 
and that the material then expires.
   - `healthCheckExpiryThreshold` declares `javaType = "java.time.Duration"`, 
so `5m` works.
   - The check id is the endpoint id plus a counter instead of a random UUID, 
so it can be correlated and two producers of one endpoint stay distinct.
   - Generated configurers, URI factory, JSON and catalog copies regenerated; 
the component and endpoint DSL factories (the rebase took main's version of the 
endpoint DSL) follow from the CI regen step, since those generators need the 
whole reactor to run locally.
   
   Unit tests green locally. #29822 adds `localSpiffeId`; the second of the two 
to merge makes this check follow the same selector (`SpiffeX509SvidSelector`) 
instead of `getDefaultSvid()`.
   
   _Claude Code on behalf of oscerd_
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to