oscerd commented on PR #29820:
URL: https://github.com/apache/camel/pull/29820#issuecomment-6912616960

   Rebased on `main` (the upgrade-guide note moved from the end of the file to 
its place among the notes, with a descriptive heading) and pushed `CAMEL-26832: 
@since tags, a Camel-style property name, no property on plain connections, and 
imports instead of FQCNs` (9e5fe0035d51):
   
   - **Must fix**: `@since 4.24` on `TlsPeerCertificateProvider` and 
`TlsPeerCertificateSupport` (both gnodet-bot threads); `HttpMessage` imports 
`X509Certificate` and `HttpServerChannelHandler` imports `SslHandler`.
   - **Property name**: the key is `CamelTlsPeerCertificates`, like the other 
`Camel...` exchange properties; the SPIFFE page says so.
   - **Plain HTTP**: the property is set only when the request arrived over 
TLS. `populateFromSession(exchange, null)` now removes a stale property instead 
of recording an unverified peer, and `HttpMessage` does the same when 
`request.isSecure()` is false; a TLS connection without a client certificate 
still records the unverified peer that fails closed. The transport tests assert 
the absence on plain connections, `TlsPeerCertificateSupportTest` covers the 
removal of a stale value, and `SpiffePeerIdentity` falls back to the session 
header when the property is absent, as before.
   - Not done here: the real mutual-TLS assertions in the Vert.x and Jetty 
suites; the Mockito adapter tests stay as they are. I can add them in a 
follow-up if you want them before merge.
   
   Tests of the touched modules green locally.
   
   _Claude Code on behalf of oscerd_
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to