gnodet-bot commented on code in PR #30162:
URL: https://github.com/apache/camel/pull/30162#discussion_r4584390928


##########
components/camel-sql/src/test/java/org/apache/camel/processor/idempotent/jdbc/JdbcOrphanLockAwareIdempotentRepositoryTest.java:
##########
@@ -81,9 +79,18 @@ public void testLockKeepAliveWorks() {
         template.update("UPDATE CAMEL_MESSAGEPROCESSED SET createdAT = ? WHERE 
processorName = ? AND messageId = ?", timestamp,
                 APP_NAME, "FILE_4");
 
-        await().atMost(5, TimeUnit.SECONDS).until(() -> 
!jdbcMessageIdRepository.contains("FILE_4"));
-        jdbcMessageIdRepository.keepAlive();
+        // the lease is older than the lock max age: another instance takes it 
for an orphan, while this instance, which
+        // holds the key, does not
+        JdbcOrphanLockAwareIdempotentRepository otherInstance
+                = new JdbcOrphanLockAwareIdempotentRepository(dataSource, 
APP_NAME, new DefaultCamelContext());
+        otherInstance.setLockMaxAgeMillis(3000_00L);

Review Comment:
   🔢 **Nit:** Non-standard digit grouping — `3000_00L` equals `300_000L` but 
breaks the conventional 3-digit grouping used consistently elsewhere in this PR 
(e.g. `300_000L`).
   
   ```suggestion
           otherInstance.setLockMaxAgeMillis(300_000L);
   ```



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to