gnodet-bot commented on code in PR #30195:
URL: https://github.com/apache/camel/pull/30195#discussion_r4584489472
##########
core/camel-support/src/main/java/org/apache/camel/support/DefaultMessageHistory.java:
##########
@@ -191,6 +190,13 @@ public void setDebugSkipOver(boolean debugSkipOver) {
this.debugSkipOver = debugSkipOver;
}
+ // an anonymous, local or hidden class (such as a lambda) has no canonical
name
+ private static String typeName(Object body) {
+ Class<?> type = body.getClass();
Review Comment:
💡 **Nit:** `typeName` shadows the name of `BodyFacts.typeName()` in the same
package, though with different semantics (this returns the canonical/binary
name, `BodyFacts.typeName()` returns simple names for `java.*` types). The call
sites are unambiguous (`BodyFacts.typeName(body)` vs bare `typeName(body)`), so
this is not a correctness issue. A distinct name like `resolveBodyTypeName`
would make the contrast explicit, but not blocking.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]