davsclaus opened a new pull request, #30204:
URL: https://github.com/apache/camel/pull/30204

   _Claude Code on behalf of davsclaus_
   
   [CAMEL-27049](https://issues.apache.org/jira/browse/CAMEL-27049)
   
   ### Problem
   
   The list of sensitive keys in `SensitiveUtils` (`SENSITIVE_KEYS` and 
`SENSITIVE_PATTERN`) is generated by `UpdateSensitizeHelper` from the 
component, data format and language catalogs. It never read the camel-main 
configuration metadata or the beans catalog, so these options are flagged 
secret but were not sensitive keys:
   
   - `camel.server.jwtKeystorePassword`
   - `camel.management.jwtKeystorePassword`
   - `camel.vault.azure.eventhubConnectionString`
   - `camel.vault.azure.tenantId`
   - `camel.vault.gcp.serviceAccountKey`
   - `camel.vault.ibm.eventStreamUsername`
   - `camel.vault.ibm.eventStreamPassword`
   
   Everything that relies on `SensitiveUtils.containsSensitive` treated them as 
ordinary options: the Camel Main auto-configuration summary showed their 
configured values instead of `xxxxxx`, and the `camel.security.secretPolicy` 
plain-text check did not report them.
   
   ### Change
   
   - `UpdateSensitizeHelper` also collects the options flagged secret in 
`main/camel-main-configuration-metadata.json` (last segment of the key) and in 
the beans catalog. Endpoint-only options are still left out, so the URI pattern 
does not get new short endpoint names.
   - The hashicorp vault keys (`jwt`, `roleid`, `secretid`) that were added by 
hand to `EXTRA_KEYS` now come from the camel-main metadata.
   - Regenerated `SensitiveUtils.java` and 
`catalog/.../main/sensitive-keys.json`. New keys: `eventhubconnectionstring`, 
`eventstreampassword`, `eventstreamusername`, `jwtkeystorepassword`, 
`serviceaccountkey`, `tenantid`.
   - Upgrade guide 4.24: these options are now masked, and 
`camel.security.secretPolicy` reports them when they are set as plain text.
   
   ### Tests
   
   - `SensitiveUtilsTest.serverAndVaultSecretOptionsAreSensitive` (camel-util): 
the seven keys are sensitive.
   - `SecretOptionsAreSensitiveKeysTest` (camel-catalog): every option flagged 
secret in the camel-main metadata, and every component, data format, language 
and bean option flagged secret, is a sensitive key, so a new secret option 
cannot be missed.
   - `MainAutoConfigurationSummaryMaskingTest` (camel-main): the 
auto-configuration summary shows `xxxxxx` for 
`camel.server.jwtKeystorePassword` and 
`camel.vault.azure.eventhubConnectionString` set in a properties file.
   
   All three fail without the regenerated key list. camel-util (345 tests), 
camel-main (338 tests) and camel-package-maven-plugin (150 tests) pass.
   
   🤖 Generated with [Claude Code](https://claude.com/claude-code)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to