apupier commented on PR #30210:
URL: https://github.com/apache/camel/pull/30210#issuecomment-6920863646
Thanks for the review. Pushed 80547ef9c582:
1. **`ExportMainApplicationPropertiesTest`**: fixed. It now extends
`CamelCommandBaseTestSupport` and calls `useTestWorkDir()`, as
`ExportMainJibTest` and `ExportMainJkubeTest` do.
2. **`AGENTS.md`**: the example is gone, and the paragraph now names the
three ways to avoid the serial fork (`exportBaseDir`, `useTestWorkDir()`, port
0). The PR description now says that the whole `ExportTest` class runs in the
parallel forks.
3. **Where the export bound 8080**: `KameletMain` does turn both servers off
for `silent`, but `--console` brings them back. In my first full run, before
any change, `ExportTest.shouldExposeConsoleWithHawtioOnSpringBoot` failed with
`BindException: Address already in use` on 8080, through `Exporter.runSilently`
-> `SilentRunDependencyResolver.resolve` -> `KameletMain.doStart` ->
`ManagementHttpServer.doStart` -> `VertxPlatformHttpServer.startServer`. The
same happened for the other `--console` tests and for the `maven-quarkus-dev`
case (14 errors in that run), and they pass with `--port=0` while 8080 is held.
I did not find which line switches the servers back on, so I can't say whether
that is intended. The golden `options` case you mention does bind its fixed
ports: with 8181 and 9191 held, `RunExportGoldenTest.export[options]` fails
with `Failed to start Vert.x HttpServer on 0.0.0.0:8181`. Those two ports are
used only by that case in the module, so the forks can't clash. I lef
t it as it is, because the golden file pins `camel.server.port=8181`.
4. **Nit**: `ExportTest` uses
`Files.createTempDirectory("camel-export-base")` now.
_IBM Bob 2.2.1 on behalf of Aurélien Pupier (@apupier)._
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]